Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable discarded history pipelineruns doesn't work #974

Merged

Conversation

yudong2015
Copy link
Collaborator

@yudong2015 yudong2015 commented Jul 10, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #970

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

fix that disable discarded history pipelineruns doesn't work

@ks-ci-bot ks-ci-bot requested a review from a team July 10, 2023 09:39
@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2023
@yudong2015
Copy link
Collaborator Author

/cherrypick release-3.4

@ks-ci-bot
Copy link
Collaborator

@yudong2015: once the present PR merges, I will cherry-pick it on top of release-3.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yudong2015 yudong2015 changed the title disable discarded history pipelineruns doesn't work wip: disable discarded history pipelineruns doesn't work Jul 11, 2023
@ks-ci-bot ks-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@yudong2015 yudong2015 changed the title wip: disable discarded history pipelineruns doesn't work disable discarded history pipelineruns doesn't work Aug 15, 2023
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2023
@chilianyi
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chilianyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@chilianyi
Copy link
Contributor

/cherrypick release-3.4

@ks-ci-bot
Copy link
Collaborator

@chilianyi: once the present PR merges, I will cherry-pick it on top of release-3.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

@yudong2015: new pull request created: #989

In response to this:

/cherrypick release-3.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to disable pipelinerun discarder after created
3 participants